Add rmdir support #2985
Add rmdir support #2985
Conversation
facundopoblete
force-pushed
the
rmdir-support
branch
from
f3a340c to
1e32dc0
Compare
Razz4780
requested review from
meowjesty and
gememma
and removed request for
Razz4780
There was a problem hiding this comment.
Implementation looks fine, think there's room for improvement around the helper function you added though.
Some of our logs are in the Thing -> {foo} format because we were using a different logging crate (or something like that) in the past. Now we mostly just stick the tracing::instrument macro on each function, and the old style is still there in some places due to us changing it only when we touch the code.
There was a problem hiding this comment.
Nice! My only suggestion other than what @meowjesty already suggested is changing the changelog file name to 2221.added.md since new features are being added rather than existing ones being changed, but up to you (I know the changlog for the mkdir support PR was fixed) :)
|
Hey @facundopoblete, sorry for not merging. We forgot that you can't do it yourself 😅 |
@Razz4780 No problem! Done |
Add support to forward the
rmdircommand to the agent